Bug 194109 – Web Inspector: Timeline time range selection should show duration alongside start and end

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Timeline time range selection should show duration alongside start and end

Currently we see something like:

    710.0ms - 1.12s

Would be nice to see:

    710.0ms - 1.12s (410ms)

Note that we can special case a zero leading digit since the end time will be clear:

    0ms - 800ms

Does not need:

    0ms - 800ms (800ms)

[Radar WebKit Bug Importer]

<rdar://problem/47714279>

[Joseph Pecoraro]

Created attachment 360776 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 360777 [details]
[IMAGE] After

[Joseph Pecoraro]

Comment on attachment 360776 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360776&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:739
> +                displayName = WI.UIString("%s \u2013 %s (%s)").format(selectionStart, selectionEnd, duration);

Oops localized string.

[Joseph Pecoraro]

Created attachment 360778 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 360778 [details]
[PATCH] Proposed Fix

rs=me

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:732
>              let selectionStart = Number.secondsToString(startValue, true);

NIT: rather than pass `true`, we should use a `const` for all of them.

    const higherResolution = true;

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:734
> +            const epsilon = 0.0001;

I get that we're using `0.0001` because it's a decimal point away from 1/1000, but should we try using `Number.EPSILON` instead?

[Joseph Pecoraro]

https://trac.webkit.org/changeset/240866/webkit