Bug 194108 – Web Inspector: Timeline time range selection sometimes shows 0.000, should be just 0

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Timeline time range selection sometimes shows 0.000, should be just 0

See attached photo.

Steps to Reproduce:
1. Inspect this page
2. Reload with a timeline
3. Make a timeline range selection
4. Drag the selection range (by the handle at the top) left and right a bunch
  => Ends up on the left with 0.000

Notes:
• Value is super small (0.000000000007) due to floating point precision

[Radar WebKit Bug Importer]

<rdar://problem/47714273>

[Joseph Pecoraro]

Created attachment 360766 [details]
[IMAGE] Issue

[Joseph Pecoraro]

Created attachment 360775 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 360775 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360775&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1159
>          const epsilon = 0.0001;

I get that we're using `0.0001` because it's a decimal point away from 1/1000, but should we try using `Number.EPSILON` instead?

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #4)
> Comment on attachment 360775 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360775&action=review
> 
> rs=me
> 
> > Source/WebInspectorUI/UserInterface/Base/Utilities.js:1159
> >          const epsilon = 0.0001;
> 
> I get that we're using `0.0001` because it's a decimal point away from
> 1/1000, but should we try using `Number.EPSILON` instead?

Yeah, that would probably be good. Lets switch to that separately!

[WebKit Commit Bot]

Comment on attachment 360775 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 360775

Committed r240824: <https://trac.webkit.org/changeset/240824>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.