194099 – [Mac] Requesting PiP from two different WebViews gets PiP window "stuck"

Bug 194099 - [Mac] Requesting PiP from two different WebViews gets PiP window "stuck"

Summary: [Mac] Requesting PiP from two different WebViews gets PiP window "stuck"

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Jer Noble

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-01-31 10:42 PST by Jer Noble
Modified:	2019-01-31 14:28 PST (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (4.27 KB, patch) 2019-01-31 10:48 PST, Jer Noble	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.44 MB, application/zip) 2019-01-31 12:44 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jer Noble 2019-01-31 10:42:03 PST

[Mac] Requesting PiP from two different WebViews gets PiP window "stuck"

Comment 1 Jer Noble 2019-01-31 10:47:28 PST

<rdar://problem/47271323>

Comment 2 Jer Noble 2019-01-31 10:48:40 PST

Created attachment 360742 [details]
Patch

Comment 3 EWS Watchlist 2019-01-31 10:50:16 PST

Attachment 360742 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:317:  The parameter name "fullscreenChangeObserver" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 EWS Watchlist 2019-01-31 12:44:10 PST Comment hidden (obsolete)

Comment on attachment 360742 [details]
Patch

Attachment 360742 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10975985

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

Comment 5 EWS Watchlist 2019-01-31 12:44:12 PST Comment hidden (obsolete)

Created attachment 360756 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

Comment 6 WebKit Commit Bot 2019-01-31 14:28:25 PST

Comment on attachment 360742 [details]
Patch

Clearing flags on attachment: 360742

Committed r240822: <https://trac.webkit.org/changeset/240822>

Comment 7 WebKit Commit Bot 2019-01-31 14:28:26 PST

All reviewed patches have been landed.  Closing bug.