Bug 194080 - Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling
Summary: Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a mac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 172917
Blocks:
  Show dependency tree / graph
 
Reported: 2019-01-30 22:33 PST by Simon Fraser (smfr)
Modified: 2019-01-31 15:28 PST (History)
9 users (show)

See Also:

Attachments
Patch (57.95 KB, patch)
2019-01-30 22:37 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
Patch (57.95 KB, patch)
2019-01-31 08:32 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-30 22:33:02 PST 
Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling
Comment 1 Simon Fraser (smfr) 2019-01-30 22:37:32 PST 
Created attachment 360693 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-01-30 22:38:05 PST 
Probably won't build without the patch from bug 172917.
Comment 3 Antti Koivisto 2019-01-30 23:28:23 PST 
Comment on attachment 360693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360693&action=review

> Source/WebCore/ChangeLog:12
> +        Add a macOS subclass, ScrollingTreeFrameScrollingNodeMac, which takes over the basic scrolling, rubber-banding
> +        and scroll snapping functionality from ScrollingTreeFrameScrollingNodeMac. The delegate owns the ScrollController and

ScrollingTreeFrameScrollingNodeMac is probably not taking over from itself
Comment 4 Simon Fraser (smfr) 2019-01-31 08:32:54 PST 
Created attachment 360729 [details]
Patch
Comment 5 Simon Fraser (smfr) 2019-01-31 15:27:10 PST 
https://trac.webkit.org/r240825
Comment 6 Radar WebKit Bug Importer 2019-01-31 15:28:28 PST 
<rdar://problem/47718823>