Bug 194070 - Don't insert spaces at the beginning of a newline when using smart-copy-paste
Summary: Don't insert spaces at the beginning of a newline when using smart-copy-paste
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-30 18:03 PST by Megan Gardner
Modified: 2019-01-31 16:39 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.14 KB, patch)
2019-01-30 18:08 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-highsierra (2.92 MB, application/zip)
2019-01-30 18:52 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.65 MB, application/zip)
2019-01-30 19:31 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-highsierra (2.52 MB, application/zip)
2019-01-30 19:50 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.53 MB, application/zip)
2019-01-30 20:14 PST, EWS Watchlist
no flags Details
Patch (9.15 KB, patch)
2019-01-30 20:20 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.39 MB, application/zip)
2019-01-30 22:17 PST, EWS Watchlist
no flags Details
Patch (9.69 KB, patch)
2019-01-31 09:36 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (9.69 KB, patch)
2019-01-31 15:59 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-01-30 18:03:25 PST
Don't insert spaces at the beginning of a newline when using smart-copy-paste
Comment 1 Megan Gardner 2019-01-30 18:08:23 PST
Created attachment 360663 [details]
Patch
Comment 2 EWS Watchlist 2019-01-30 18:52:06 PST
Comment on attachment 360663 [details]
Patch

Attachment 360663 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10961812

New failing tests:
editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html
Comment 3 EWS Watchlist 2019-01-30 18:52:08 PST
Created attachment 360670 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2019-01-30 19:31:28 PST
Comment on attachment 360663 [details]
Patch

Attachment 360663 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10962234

New failing tests:
editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html
Comment 5 EWS Watchlist 2019-01-30 19:31:30 PST
Created attachment 360678 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 EWS Watchlist 2019-01-30 19:50:16 PST
Comment on attachment 360663 [details]
Patch

Attachment 360663 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10962200

New failing tests:
editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html
Comment 7 EWS Watchlist 2019-01-30 19:50:17 PST
Created attachment 360680 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-01-30 20:14:57 PST
Comment on attachment 360663 [details]
Patch

Attachment 360663 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10962513

New failing tests:
editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html
Comment 9 EWS Watchlist 2019-01-30 20:14:59 PST
Created attachment 360682 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 10 Megan Gardner 2019-01-30 20:20:11 PST
Created attachment 360683 [details]
Patch
Comment 11 EWS Watchlist 2019-01-30 22:17:22 PST
Comment on attachment 360683 [details]
Patch

Attachment 360683 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10964447

New failing tests:
editing/pasteboard/mac/copy-smartpaste-first-line-in-textarea.html
Comment 12 EWS Watchlist 2019-01-30 22:17:24 PST
Created attachment 360692 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 13 Megan Gardner 2019-01-31 09:36:14 PST
Created attachment 360735 [details]
Patch
Comment 14 Tim Horton 2019-01-31 14:41:10 PST
Comment on attachment 360735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360735&action=review

> Source/WebCore/ChangeLog:9
> +        Also, if our inserted content beginning is at the end of a paragar, do not instert a space.

PARAGAR
INSTERT

> LayoutTests/ChangeLog:7
> +        Rebaseline a test the is dependant on a console log that changes lines.

"the is"

> LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt:1
> -CONSOLE MESSAGE: line 88: The download attribute on anchor was ignored because its href URL has a different security origin.
> +CONSOLE MESSAGE: line 107: The download attribute on anchor was ignored because its href URL has a different security origin.

:|

> LayoutTests/resources/ui-helper.js:135
> +            // only here to deal with async/sync copy/paste calls.
> +            // once <rdar://problem/16207002> is resolved, should be able to remove for faster tests.

Capitals, whole sentences, etc.
Comment 15 Megan Gardner 2019-01-31 15:59:53 PST
Created attachment 360799 [details]
Patch for landing
Comment 16 WebKit Commit Bot 2019-01-31 16:39:01 PST
Comment on attachment 360799 [details]
Patch for landing

Clearing flags on attachment: 360799

Committed r240829: <https://trac.webkit.org/changeset/240829>
Comment 17 WebKit Commit Bot 2019-01-31 16:39:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2019-01-31 16:39:33 PST
<rdar://problem/47721461>