Bug 194061 - [macOS] Disable permissive call logging in sandbox
Summary: [macOS] Disable permissive call logging in sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-30 16:21 PST by Per Arne Vollan
Modified: 2019-02-27 11:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2019-01-30 16:23 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.07 KB, patch)
2019-02-01 09:46 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2019-02-04 09:52 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (3.10 MB, application/zip)
2019-02-04 14:33 PST, EWS Watchlist 		no flags Details
Patch (1.39 KB, patch)
2019-02-26 16:45 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-01-30 16:21:27 PST 
We should reenable strict call filtering.
Comment 1 Per Arne Vollan 2019-01-30 16:23:16 PST 
Created attachment 360641 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-01-30 16:24:05 PST 
<rdar://problem/47686253>
Comment 3 Alexey Proskuryakov 2019-01-31 12:51:04 PST 
Comment on attachment 360641 [details]
Patch

r=me assuming that tests pass
Comment 4 Per Arne Vollan 2019-01-31 13:27:14 PST 
Comment on attachment 360641 [details]
Patch

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2019-01-31 13:43:08 PST 
Comment on attachment 360641 [details]
Patch

Clearing flags on attachment: 360641

Committed r240811: <https://trac.webkit.org/changeset/240811>
Comment 6 WebKit Commit Bot 2019-01-31 13:43:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Per Arne Vollan 2019-02-01 09:46:03 PST 
Reopening to attach new patch.
Comment 8 Per Arne Vollan 2019-02-01 09:46:04 PST 
Created attachment 360867 [details]
Patch
Comment 9 Per Arne Vollan 2019-02-01 09:52:59 PST 
Partly reverted original patch in <https://trac.webkit.org/changeset/240857/webkit>, since it still causes panics.
Comment 10 Per Arne Vollan 2019-02-04 09:52:20 PST 
Created attachment 361065 [details]
Patch
Comment 11 EWS Watchlist 2019-02-04 14:33:47 PST 
Comment on attachment 361065 [details]
Patch

Attachment 361065 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11029165

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html
Comment 12 EWS Watchlist 2019-02-04 14:33:48 PST 
Created attachment 361102 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 13 Alexey Proskuryakov 2019-02-04 17:00:05 PST 
Comment on attachment 361065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361065&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:964
> +        (syscall-number SYS_kdebug_typefilter)

I'd be curious to know how you found that it's the one. And I'm more and more unsure if we want to do this filtering at all.
Comment 14 Per Arne Vollan 2019-02-26 16:45:25 PST 
Created attachment 363036 [details]
Patch
Comment 15 Brent Fulgham 2019-02-27 11:07:38 PST 
Comment on attachment 363036 [details]
Patch

r=me. Simulator crash does not seem related.
Comment 16 Per Arne Vollan 2019-02-27 11:20:53 PST 
Comment on attachment 363036 [details]
Patch

Thanks for reviewing!
Comment 17 WebKit Commit Bot 2019-02-27 11:47:59 PST 
Comment on attachment 363036 [details]
Patch

Clearing flags on attachment: 363036

Committed r242141: <https://trac.webkit.org/changeset/242141>
Comment 18 WebKit Commit Bot 2019-02-27 11:48:01 PST 
All reviewed patches have been landed.  Closing bug.