Bug 194058 - Add default constructor for NetworkActivityTracker
Summary: Add default constructor for NetworkActivityTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-30 16:03 PST by Keith Rollin
Modified: 2019-01-30 17:55 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2019-01-30 16:05 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2019-01-30 16:32 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-30 16:03:10 PST
ResourceNetworkActivityTracker has a default constructor. It also has a NetworkActivityTracker data member, which does not have a default constructor. This will cause some compilers to complain -- they can't default-create a ResourceNetworkActivityTracker because they can't default-create its data members. Address this by adding a default constructor for NetworkActivityTracker.
Comment 1 Radar WebKit Bug Importer 2019-01-30 16:03:28 PST
<rdar://problem/47685457>
Comment 2 Keith Rollin 2019-01-30 16:05:40 PST
Created attachment 360638 [details]
Patch
Comment 3 Chris Dumez 2019-01-30 16:07:49 PST
Comment on attachment 360638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360638&action=review

> Source/WebKit/NetworkProcess/NetworkActivityTracker.h:68
>      NetworkActivityTracker(Label, Domain = Domain::WebKit);

explicit ?
Comment 4 Keith Rollin 2019-01-30 16:32:54 PST
Created attachment 360644 [details]
Patch
Comment 5 WebKit Commit Bot 2019-01-30 17:55:33 PST
Comment on attachment 360644 [details]
Patch

Clearing flags on attachment: 360644

Committed r240747: <https://trac.webkit.org/changeset/240747>
Comment 6 WebKit Commit Bot 2019-01-30 17:55:34 PST
All reviewed patches have been landed.  Closing bug.