Bug 194048 – [WebGPU] Support GPUDepthStencilStateDescriptor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[WebGPU] Support GPUDepthStencilStateDescriptor

[Justin Fan]

<rdar://problem/46289645>

[Justin Fan]

Created attachment 360626 [details]
Patch

[Dean Jackson]

Comment on attachment 360626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360626&action=review

> Source/WebCore/Modules/webgpu/WebGPUCompareFunction.h:34
> +using WebGPUCompareFunction = GPUCompareFunction;

I wonder if we even need the ImplementedAs in this case, since we're actually using exactly the same thing.

> Source/WebCore/Modules/webgpu/WebGPUDepthStencilStateDescriptor.h:34
> +using WebGPUDepthStencilStateDescriptor = GPUDepthStencilStateDescriptor;

Same here.

[Justin Fan]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 360626 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360626&action=review
> 
> > Source/WebCore/Modules/webgpu/WebGPUCompareFunction.h:34
> > +using WebGPUCompareFunction = GPUCompareFunction;
> 
> I wonder if we even need the ImplementedAs in this case, since we're
> actually using exactly the same thing.
> 
> > Source/WebCore/Modules/webgpu/WebGPUDepthStencilStateDescriptor.h:34
> > +using WebGPUDepthStencilStateDescriptor = GPUDepthStencilStateDescriptor;
> 
> Same here.


Same. I'm all for just using the GPU* versions.

[Justin Fan]

Created attachment 360650 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 360650 [details]
Patch for landing

Clearing flags on attachment: 360650

Committed r240748: <https://trac.webkit.org/changeset/240748>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.