Bug 194046 – testapi's `testBytecodeCache` does not need to run the code twice

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

Since we populate the cache eagerly (unlike the stress tests) we don't need to run the code twice.

[Tadeu Zagallo]

Created attachment 360618 [details]
Patch

[Mark Lam]

Comment on attachment 360618 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 360618 [details]
Patch

Rejecting attachment 360618 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 360618, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=360618&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=194046&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 360618 from bug 194046.
Fetching: https://bugs.webkit.org/attachment.cgi?id=360618
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/API/tests/testapi.mm
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: 55440ac93da99bc994e82a2e1ae6a5a468e8cc55 and refs/remotes/origin/master differ, using rebase:
:040000 040000 a12a397647e5b95fae2d59cef74aedbf9cb08859 c53753ff86e001b637539b9f8f1254059d22aef7 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/API/tests/testapi.mm
	M	Source/JavaScriptCore/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date
W: 55440ac93da99bc994e82a2e1ae6a5a468e8cc55 and refs/remotes/origin/master differ, using rebase:
:040000 040000 a12a397647e5b95fae2d59cef74aedbf9cb08859 c53753ff86e001b637539b9f8f1254059d22aef7 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10958001

[Tadeu Zagallo]

Created attachment 360645 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 360645 [details]
Patch for landing

Rejecting attachment 360645 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 360645, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10960789

[Tadeu Zagallo]

Created attachment 360661 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 360661 [details]
Patch for landing

Clearing flags on attachment: 360661

Committed r240753: <https://trac.webkit.org/changeset/240753>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47691091>