RESOLVED FIXED 194045
CachedBytecode move constructor should not call `freeDataIfOwned` 
https://bugs.webkit.org/show_bug.cgi?id=194045
Summary CachedBytecode move constructor should not call `freeDataIfOwned`
Tadeu Zagallo
Reported 2019-01-30 13:51:43 PST
That might result in freeing a garbage value
Attachments
Patch (1.42 KB, patch)
2019-01-30 13:53 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-01-30 13:53:12 PST
Created attachment 360615 [details] Patch
Mark Lam
Comment 2 2019-01-30 14:02:51 PST
Comment on attachment 360615 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-01-30 14:56:52 PST
Comment on attachment 360615 [details] Patch Clearing flags on attachment: 360615 Committed r240732: <https://trac.webkit.org/changeset/240732>
WebKit Commit Bot
Comment 4 2019-01-30 14:56:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-01-30 14:57:30 PST
<rdar://problem/47682823>
Darin Adler
Comment 6 2019-02-01 08:25:32 PST
Just a meta-note about the mistake that led to this bug. Generally speaking in any non-trivial cases, we can implement operator= by calling the constructor in an appropriate way, and that's often a good pattern, but it's typically not good in such cases to attempt to implement a constructor by calling operator=.
Note You need to log in before you can comment on or make changes to this bug.