Bug 194038 - WasmB3IRGenerator models some effects incorrectly
Summary: WasmB3IRGenerator models some effects incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-30 13:24 PST by Saam Barati
Modified: 2019-03-14 17:11 PDT (History)
6 users (show)

See Also:

Attachments
WIP (3.81 KB, patch)
2019-01-30 13:25 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (5.09 KB, patch)
2019-02-17 11:58 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-01-30 13:24:58 PST 
...
Comment 1 Saam Barati 2019-01-30 13:25:51 PST 
Created attachment 360607 [details]
WIP
Comment 2 Saam Barati 2019-02-17 11:58:23 PST 
Created attachment 362240 [details]
patch
Comment 3 Keith Miller 2019-02-17 13:20:30 PST 
Comment on attachment 362240 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362240&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:-320
> -    patchpoint->append(instanceValue(), ValueRep::SomeRegister);

How did this ever work?... I guess we just usually don’t take this path and/or B3 rematerialized the value?
Comment 4 Saam Barati 2019-02-17 20:13:14 PST 
Comment on attachment 362240 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362240&action=review

>> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:-320
>> -    patchpoint->append(instanceValue(), ValueRep::SomeRegister);
> 
> How did this ever work?... I guess we just usually don’t take this path and/or B3 rematerialized the value?

Dunno. Maybe the non-Darwin ports aren’t testing Wasm?
Comment 5 WebKit Commit Bot 2019-02-17 20:40:19 PST 
Comment on attachment 362240 [details]
patch

Clearing flags on attachment: 362240

Committed r241657: <https://trac.webkit.org/changeset/241657>
Comment 6 WebKit Commit Bot 2019-02-17 20:40:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-02-17 20:41:21 PST 
<rdar://problem/48153007>