Bug 194037 - Remove assertion that CachedSymbolTables should have no RareData
Summary: Remove assertion that CachedSymbolTables should have no RareData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
: 194430 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-01-30 13:22 PST by Tadeu Zagallo
Modified: 2019-02-08 00:55 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2019-01-30 13:45 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (1.80 KB, patch)
2019-01-30 14:08 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (1.80 KB, patch)
2019-01-30 15:03 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-01-30 13:22:52 PST 
It turns out that we don't need to cache the SymbolTableRareData, but we should not assert that it's null.
Comment 1 Tadeu Zagallo 2019-01-30 13:45:59 PST 
Created attachment 360612 [details]
Patch
Comment 2 Mark Lam 2019-01-30 14:06:39 PST 
Comment on attachment 360612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360612&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        It turns out that we don't need to cache the SymbolTableRareData, but
> +        we should not assert that it's empty.

nit: Do you mean 'and we should not assert ..."?
Comment 3 Tadeu Zagallo 2019-01-30 14:08:42 PST 
Created attachment 360619 [details]
Patch for landing
Comment 4 Tadeu Zagallo 2019-01-30 15:03:50 PST 
Created attachment 360629 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-01-30 16:47:04 PST 
Comment on attachment 360629 [details]
Patch for landing

Clearing flags on attachment: 360629

Committed r240739: <https://trac.webkit.org/changeset/240739>
Comment 6 WebKit Commit Bot 2019-01-30 16:47:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-30 16:48:38 PST 
<rdar://problem/47687176>
Comment 8 Saam Barati 2019-01-30 23:41:48 PST 
Comment on attachment 360629 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=360629&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        It turns out that we don't need to cache the SymbolTableRareData and

It’s worth describing why here.
Comment 9 Tadeu Zagallo 2019-02-08 00:55:46 PST 
*** Bug 194430 has been marked as a duplicate of this bug. ***