Run the attached test case in a debug build. ASSERT(!text.isEmpty()) inside InsertIntoTextNodeCommand::InsertIntoTextNodeCommand fires because RemoveFormat calls input with an empty String. plainText() is returning an empty string for a Range selection for some reason...
Created attachment 21516 [details] test case
Created attachment 21519 [details] patch
Comment on attachment 21519 [details] patch Looks good. The if (string.isEmpty()) should have a comment before it explaning "why", since I'm not sure it will be clear to either of us why it's there in 9 months. :) If you strongly disagree I'm fine w/ you to landing w/o comment. I don't need to see your final patch again either way. :)
(In reply to comment #3) > (From update of attachment 21519 [details] [edit]) > Looks good. The if (string.isEmpty()) should have a comment before it > explaning "why", since I'm not sure it will be clear to either of us why it's > there in 9 months. :) You're right. Fixed that. http://trac.webkit.org/changeset/34399