Bug 194015 - [JSC] Make global static variables "const" as much as possible
Summary: [JSC] Make global static variables "const" as much as possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 193606
  Show dependency tree / graph
 
Reported: 2019-01-30 04:53 PST by Yusuke Suzuki
Modified: 2019-01-30 12:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (9.09 KB, patch)
2019-01-30 04:54 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-01-30 04:53:41 PST 
[JSC] Make global static variables "const" as much as possible
Comment 1 Yusuke Suzuki 2019-01-30 04:54:57 PST 
Created attachment 360571 [details]
Patch
Comment 2 EWS Watchlist 2019-01-30 04:56:46 PST 
Attachment 360571 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generator.py:146:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2019-01-30 10:11:12 PST 
Comment on attachment 360571 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2019-01-30 10:53:36 PST 
Thanks!
Comment 5 Yusuke Suzuki 2019-01-30 10:55:43 PST 
Committed r240718: <https://trac.webkit.org/changeset/240718>
Comment 6 Radar WebKit Bug Importer 2019-01-30 10:57:37 PST 
<rdar://problem/47673047>
Comment 7 Yusuke Suzuki 2019-01-30 12:27:56 PST 
Committed r240726: <https://trac.webkit.org/changeset/240726>