WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
19401
Layout-test results for media/video-controls-rendering.html loses backgroundClip and outlineClip after change to html4.css
https://bugs.webkit.org/show_bug.cgi?id=19401
Summary
Layout-test results for media/video-controls-rendering.html loses backgroundC...
Tor Arne Vestbø
Reported
2008-06-05 06:38:01 PDT
Change
r34299
modified html4.css to allow media element controls to be placed anywhere on the media element, and updated the default positioning to be based on the bottom of the media element, not the top. This caused regressions in three layout-tests which were updated in
r34376
. One of these (media/video-controls-rendering.html) had the following diff: -layer at (8,746) size 320x18 backgroundClip at (0,0) size 785x762 clip at (0,0) size 785x762 outlineClip at (0,0) size 785x762 - RenderBlock (positioned) {DIV} at (0,224) size 320x16 +layer at (8,522) size 320x240 + RenderBlock (positioned) {DIV} at (0,0) size 320x240 The question is, why do we loose backgroundClip and outlineClip here, and does it matter? Visually, the actual results look the same as before, so we safely assumed we could update the results, but in case these two changes (backgroundClip and outlineClip) actually do something we need to go back and investigate further.
Attachments
Add attachment
proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1
2009-09-10 01:35:47 PDT
Assuming this was OK after all.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug