Bug 193994 - fast/events/ios/rotation/zz-no-rotation.html indicates it has inter-test dependency
Summary: fast/events/ios/rotation/zz-no-rotation.html indicates it has inter-test depe...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-29 15:55 PST by Jonathan Bedard
Modified: 2019-01-30 10:26 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-01-29 15:55:51 PST 
At the moment, this test is meaningful (although broken on iPad). However, nothing about WebKitTestRunner grantees test order will be respected. We already have a mode now, --run-singly, which breaks the assumption of this test. This test should either be removed entirely or combined with the 'previous test' mentioned in the test.
Comment 1 Jonathan Bedard 2019-01-29 15:56:11 PST 
Test Wass added in <https://trac.webkit.org/changeset/216291/webkit>
Comment 2 Jonathan Bedard 2019-01-29 16:03:50 PST 
(In reply to Jonathan Bedard from comment #1)
> Test Wass added in <https://trac.webkit.org/changeset/216291/webkit>

*was added
Comment 3 Simon Fraser (smfr) 2019-01-29 16:05:01 PST 
It's hard to test device rotation. This was the best I could do.
Comment 4 Jonathan Bedard 2019-01-29 16:17:31 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> It's hard to test device rotation. This was the best I could do.

Ok, so that means that (at least in the current state) we cannot combine this with the previous test. I would like to eventually figure a better way to do this, but it's not critical at the moment.