Bug 193992 – <rdar://problem/29471922> Safari should switch from the legacy denap SPI to handling vouchers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

<rdar://problem/29471922> Safari should switch from the legacy denap SPI to handling vouchers

[Benjamin Poulain]

Created attachment 360513 [details]
Patch

[Benjamin Poulain]

<rdar://problem/29471922>

[Geoffrey Garen]

Comment on attachment 360513 [details]
Patch

r=me

[Benjamin Poulain]

Thanks for the review Geoff.

[WebKit Commit Bot]

Comment on attachment 360513 [details]
Patch

Rejecting attachment 360513 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 360513, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=360513&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=193992&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 360513 from bug 193992.
Fetching: https://bugs.webkit.org/attachment.cgi?id=360513
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: b8f58fdc2bf84cbb63f157ac849484cd8b1dfe76 and refs/remotes/origin/master differ, using rebase:
:040000 040000 6327cbb7ba571fd0bb483d70dc049e6d8ada6e4b c53753ff86e001b637539b9f8f1254059d22aef7 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: b8f58fdc2bf84cbb63f157ac849484cd8b1dfe76 and refs/remotes/origin/master differ, using rebase:
:040000 040000 6327cbb7ba571fd0bb483d70dc049e6d8ada6e4b c53753ff86e001b637539b9f8f1254059d22aef7 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/10958097

[Benjamin Poulain]

Created attachment 360646 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 360646 [details]
Patch for landing

Clearing flags on attachment: 360646

Committed r240745: <https://trac.webkit.org/changeset/240745>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Just checking: Is this compatible with all the oldest versions of macOS that we currently support with TOT WebKit?

[Benjamin Poulain]

(In reply to Darin Adler from comment #9)
> Just checking: Is this compatible with all the oldest versions of macOS that
> we currently support with TOT WebKit?

The vouchers are at least supported in >= Mojave.

Sorry I forgot the policy. How far back do we have to support?

[Geoffrey Garen]

It looks like MACH_RCV_VOUCHER and mach_voucher_deallocate were introduced in macOS 10.10 Yosemite (four macOS releases ago) -- at the same time as proc_denap_assertion_begin_with_msg() / proc_denap_assertion_complete().

So, we might need to do some testing, but I think we're OK here.