Web Inspector: Styles: enable computed style cascades by default

[Nikita Vasilyev]

<rdar://problem/47645821>

[Nikita Vasilyev]

Created attachment 360502 [details]
Patch

[Nikita Vasilyev]

Note that this patch doesn't remove a lot of the old code. The Variables section is still based on SpreadsheetCSSStyleDeclarationEditor and uses the old computed tab logic.

[Matt Baker]

Comment on attachment 360502 [details]
Patch

rs=me

[Devin Rousso]

Comment on attachment 360502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360502&action=review

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:107
>  

Style: remove this newline.

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:32
> +        this.element.classList.add("computed-with-traces");

Rather than just always adding this class, why not merge the styles?

[Nikita Vasilyev]

Created attachment 360504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360502&action=review

>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:32
>> +        this.element.classList.add("computed-with-traces");
> 
> Rather than just always adding this class, why not merge the styles?

Sure, that was actually not that hard!

[WebKit Commit Bot]

Comment on attachment 360504 [details]
Patch

Clearing flags on attachment: 360504

Committed r240691: <https://trac.webkit.org/changeset/240691>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.