Bug 193979 - REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
Summary: REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is faili...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-29 13:38 PST by Truitt Savell
Modified: 2019-01-30 19:57 PST (History)
7 users (show)

See Also:

Attachments
Fixes the test (1.71 KB, patch)
2019-01-30 17:51 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-01-29 13:38:34 PST 
WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing on iOS after being introduced in https://trac.webkit.org/changeset/240541/webkit

Failed

    TestWebKitAPI.WebKit.WebsitePoliciesCustomJavaScriptUserAgent
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
Comment 1 Alexey Proskuryakov 2019-01-30 10:29:49 PST 
Ryosuke, can you look into this today, or should the change be rolled back?
Comment 2 Ryosuke Niwa 2019-01-30 17:45:03 PST 
Ugh... of course. iOS has a different UA string.
Comment 3 Ryosuke Niwa 2019-01-30 17:51:36 PST 
Created attachment 360660 [details]
Fixes the test
Comment 4 Ryosuke Niwa 2019-01-30 19:56:20 PST 
Comment on attachment 360660 [details]
Fixes the test

Clearing flags on attachment: 360660

Committed r240756: <https://trac.webkit.org/changeset/240756>
Comment 5 Ryosuke Niwa 2019-01-30 19:56:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-30 19:57:29 PST 
<rdar://problem/47691812>