Bug 193979 – REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Truitt Savell]

WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing on iOS after being introduced in https://trac.webkit.org/changeset/240541/webkit

Failed

    TestWebKitAPI.WebKit.WebsitePoliciesCustomJavaScriptUserAgent
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142
        Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143
        Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"]
          Actual: false
        Expected: true

[Alexey Proskuryakov]

Ryosuke, can you look into this today, or should the change be rolled back?

[Ryosuke Niwa]

Ugh... of course. iOS has a different UA string.

[Ryosuke Niwa]

Created attachment 360660 [details]
Fixes the test

[Ryosuke Niwa]

Comment on attachment 360660 [details]
Fixes the test

Clearing flags on attachment: 360660

Committed r240756: <https://trac.webkit.org/changeset/240756>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47691812>