Bug 193977 - REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
Summary: REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-29 13:25 PST by Truitt Savell
Modified: 2019-01-29 17:16 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2019-01-29 15:09 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.91 KB, patch)
2019-01-29 15:50 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-01-29 13:25:44 PST
ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted API test began failing continuously

failure appears to have begun around r240485 from looking at the build history:
https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29?numbuilds=200

Failed

    TestWebKitAPI.ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2304
        Expected equality of these values:
          webkitPID
            Which is: 51835
          [webView _webProcessIdentifier]
            Which is: 51837
        

I have do not have repro steps yet
Comment 1 Chris Dumez 2019-01-29 13:29:02 PST
Thanks, I am looking into this.
Comment 2 Radar WebKit Bug Importer 2019-01-29 13:29:33 PST
<rdar://problem/47643716>
Comment 3 Chris Dumez 2019-01-29 14:33:15 PST
I can reproduce.
Comment 4 Chris Dumez 2019-01-29 15:09:45 PST
Created attachment 360505 [details]
Patch
Comment 5 Geoffrey Garen 2019-01-29 15:46:18 PST
Comment on attachment 360505 [details]
Patch

r=me
Comment 6 Chris Dumez 2019-01-29 15:50:36 PST
Created attachment 360516 [details]
Patch
Comment 7 WebKit Commit Bot 2019-01-29 17:16:10 PST
Comment on attachment 360516 [details]
Patch

Clearing flags on attachment: 360516

Committed r240695: <https://trac.webkit.org/changeset/240695>
Comment 8 WebKit Commit Bot 2019-01-29 17:16:12 PST
All reviewed patches have been landed.  Closing bug.