Bug 193950 – User agent string override for navigator.userAgent should be site specific quirks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ryosuke Niwa]

In order to make it possible to toggle the UA string override just for navigator.userAgent via Web Inspector,
we need to put this behind the site specific quirks.

[Ryosuke Niwa]

Created attachment 360425 [details]
Hides behind site specific quirks

[Brent Fulgham]

Comment on attachment 360425 [details]
Hides behind site specific quirks

View in context: https://bugs.webkit.org/attachment.cgi?id=360425&action=review

> Source/WebCore/loader/FrameLoader.cpp:2719
> +            auto userAgent = documentLoader->customJavaScriptUserAgentAsSiteSpecificQuirks();

I don't think you want to declare it 'auto' here -- won't it go out of scope after this line?

[Ryosuke Niwa]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 360425 [details]
> Hides behind site specific quirks
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360425&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2719
> > +            auto userAgent = documentLoader->customJavaScriptUserAgentAsSiteSpecificQuirks();
> 
> I don't think you want to declare it 'auto' here -- won't it go out of scope
> after this line?

Oh oops, I forgot to remove that auto after moving the code around.

[Ryosuke Niwa]

Created attachment 360429 [details]
Removed superflous auto

[Brent Fulgham]

Comment on attachment 360429 [details]
Removed superflous auto

r=mews

[Ryosuke Niwa]

Oops, I forgot to enable SiteSpecificQuirks in API tests.

[Ryosuke Niwa]

Created attachment 360430 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 360430 [details]
Patch for landing

Wait for EWS

[Ryosuke Niwa]

Created attachment 360437 [details]
Fixed iOS build

[Ryosuke Niwa]

Committed r240646: <https://trac.webkit.org/changeset/240646>

[Radar WebKit Bug Importer]

<rdar://problem/47624338>