Bug 193929 - Move platform-specific files out of WTF root directory.
Summary: Move platform-specific files out of WTF root directory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-28 15:18 PST by Ross Kirsling
Modified: 2019-01-28 20:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (104.26 KB, patch)
2019-01-28 15:19 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (146.89 KB, patch)
2019-01-28 19:15 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-01-28 15:18:56 PST 
Move platform-specific files out of WTF root directory.
Comment 1 Ross Kirsling 2019-01-28 15:19:41 PST 
Created attachment 360384 [details]
Patch
Comment 2 EWS Watchlist 2019-01-28 15:23:15 PST 
Attachment 360384 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WTF/wtf/cf/RunLoopTimerCF.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:88:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:116:  MS_VC_EXCEPTION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:214:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/win/ThreadingWin.cpp:342:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/win/OSAllocatorWin.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 7 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ross Kirsling 2019-01-28 16:35:40 PST 
I'd be happy to move ThreadingPthreads.cpp to posix/ at the same time, but I wonder if the filename should be updated to ThreadingPOSIX.cpp then?
Comment 4 Ross Kirsling 2019-01-28 19:15:46 PST 
Created attachment 360419 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-01-28 20:00:15 PST 
Comment on attachment 360419 [details]
Patch for landing

Clearing flags on attachment: 360419

Committed r240636: <https://trac.webkit.org/changeset/240636>
Comment 6 WebKit Commit Bot 2019-01-28 20:00:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-28 20:01:38 PST 
<rdar://problem/47621312>