Bug 193928 - [ews-app] Make the results url generic
Summary: [ews-app] Make the results url generic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-28 15:16 PST by Aakash Jain
Modified: 2019-01-29 12:54 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (1.26 KB, patch)
2019-01-28 15:20 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-28 15:16:46 PST
Currently ews-app url to submit results contains patch_id in it. This works for 'build' event result, but not for 'step' event results, since step events results do not contain patch_id. We should make the url to accept result generic, so that it can accept any kind of data. Data verification can be done after receiving and parsing the data.
Comment 1 Aakash Jain 2019-01-28 15:20:26 PST
Created attachment 360385 [details]
Proposed patch
Comment 2 Lucas Forschler 2019-01-28 15:24:10 PST
Comment on attachment 360385 [details]
Proposed patch

Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place.
Comment 3 Aakash Jain 2019-01-28 15:33:19 PST
> Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place.
Nothing in production. Next patch coming soon to process the data which comes through /results/ path.
Comment 4 Aakash Jain 2019-01-29 12:12:45 PST
> Next patch coming soon to process the data which comes through /results/ path.
https://bugs.webkit.org/show_bug.cgi?id=193973 has patch to handle the results data.

https://bugs.webkit.org/show_bug.cgi?id=193968 has patch which starts sending data to this results url.
Comment 5 WebKit Commit Bot 2019-01-29 12:53:23 PST
Comment on attachment 360385 [details]
Proposed patch

Clearing flags on attachment: 360385

Committed r240673: <https://trac.webkit.org/changeset/240673>
Comment 6 WebKit Commit Bot 2019-01-29 12:53:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-29 12:54:27 PST
<rdar://problem/47642499>