Bug 193927 - [Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
Summary: [Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WK...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-28 15:15 PST by Andy Estes
Modified: 2019-01-28 17:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2019-01-28 15:24 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2019-01-28 15:42 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-01-28 15:15:20 PST 
[Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
Comment 1 Andy Estes 2019-01-28 15:24:19 PST 
Created attachment 360387 [details]
Patch
Comment 2 Tim Horton 2019-01-28 15:28:07 PST 
Comment on attachment 360387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360387&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:38
>  - (id)_initWithWKContentRuleListStore:(WKContentRuleListStore*)contentRuleListStore WK_API_AVAILABLE(macosx(10.13), ios(11.0));

Odd that this has WK in the name :| Also the star.
Comment 3 Andy Estes 2019-01-28 15:41:42 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 360387 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360387&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:38
> >  - (id)_initWithWKContentRuleListStore:(WKContentRuleListStore*)contentRuleListStore WK_API_AVAILABLE(macosx(10.13), ios(11.0));
> 
> Odd that this has WK in the name :| Also the star.

Indeed :(

Will drive-by fix the star, at least.
Comment 4 Andy Estes 2019-01-28 15:42:47 PST 
Created attachment 360390 [details]
Patch
Comment 5 WebKit Commit Bot 2019-01-28 17:12:36 PST 
Comment on attachment 360390 [details]
Patch

Clearing flags on attachment: 360390

Committed r240624: <https://trac.webkit.org/changeset/240624>
Comment 6 WebKit Commit Bot 2019-01-28 17:12:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-28 17:13:30 PST 
<rdar://problem/47617634>