Bug 193920 - ToString node actually does GC.
Summary: ToString node actually does GC.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-28 12:47 PST by Mark Lam
Modified: 2019-01-28 16:41 PST (History)
9 users (show)

See Also:

Attachments
proposed patch. (6.21 KB, patch)
2019-01-28 15:14 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-01-28 12:47:06 PST 
Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC().

<rdar://problem/46695900>
Comment 1 Saam Barati 2019-01-28 13:19:56 PST 
(In reply to Mark Lam from comment #0)
> Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC().
> 
> <rdar://problem/46695900>

What does clobberize say?
Comment 2 Mark Lam 2019-01-28 13:30:30 PST 
(In reply to Saam Barati from comment #1)
> (In reply to Mark Lam from comment #0)
> > Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC().
> > 
> > <rdar://problem/46695900>
> 
> What does clobberize say?

Cloberrize says:
    def(PureValue(node));

... which defers to doesGC(), which says false.  So, it's wrong.
Comment 3 Mark Lam 2019-01-28 15:14:14 PST 
Created attachment 360383 [details]
proposed patch.
Comment 4 Yusuke Suzuki 2019-01-28 15:26:55 PST 
Comment on attachment 360383 [details]
proposed patch.

r=me
Comment 5 Mark Lam 2019-01-28 16:14:43 PST 
Thanks for the review.  Landing now.
Comment 6 WebKit Commit Bot 2019-01-28 16:41:50 PST 
Comment on attachment 360383 [details]
proposed patch.

Clearing flags on attachment: 360383

Committed r240616: <https://trac.webkit.org/changeset/240616>
Comment 7 WebKit Commit Bot 2019-01-28 16:41:52 PST 
All reviewed patches have been landed.  Closing bug.