Bug 193913 - [macOS] Crash when control-clicking or copying text rendered with a web font
Summary: [macOS] Crash when control-clicking or copying text rendered with a web font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac macOS 10.13
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-28 10:15 PST by Per Arne Vollan
Modified: 2019-01-31 13:41 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2019-01-28 10:18 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2019-01-28 10:28 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-01-28 10:15:06 PST 
This was caused by <https://trac.webkit.org/r239963>.
Comment 1 Per Arne Vollan 2019-01-28 10:15:27 PST 
rdar://problem/47541039
Comment 2 Per Arne Vollan 2019-01-28 10:18:47 PST 
Created attachment 360349 [details]
Patch
Comment 3 mitz 2019-01-28 10:21:15 PST 
Comment on attachment 360349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360349&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300

Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should always use either >= or <, never <= or >.
Comment 4 Per Arne Vollan 2019-01-28 10:28:50 PST 
Created attachment 360354 [details]
Patch
Comment 5 Per Arne Vollan 2019-01-28 10:29:29 PST 
(In reply to mitz from comment #3)
> Comment on attachment 360349 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360349&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575
> > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300
> 
> Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should
> always use either >= or <, never <= or >.

Thanks for reviewing! I have updated the patch.
Comment 6 Per Arne Vollan 2019-01-31 12:04:37 PST 
I have confirmed locally that this patch fixes the crash.
Comment 7 Brent Fulgham 2019-01-31 13:15:38 PST 
Comment on attachment 360354 [details]
Patch

r=me
Comment 8 Per Arne Vollan 2019-01-31 13:24:36 PST 
Comment on attachment 360354 [details]
Patch

Thanks for reviewing!
Comment 9 WebKit Commit Bot 2019-01-31 13:41:04 PST 
Comment on attachment 360354 [details]
Patch

Clearing flags on attachment: 360354

Committed r240810: <https://trac.webkit.org/changeset/240810>
Comment 10 WebKit Commit Bot 2019-01-31 13:41:06 PST 
All reviewed patches have been landed.  Closing bug.