Bug 193896 - [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
Summary: [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through ma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-27 21:55 PST by zalan
Modified: 2019-01-28 08:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.82 KB, patch)
2019-01-28 08:09 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-27 21:55:33 PST 
<div style="border: 1px solid green">
  <div>
    <p>
  </div>
</div>
p's 16px quirk margin gets collapsed all the way up.
Comment 1 zalan 2019-01-28 08:09:55 PST 
Created attachment 360342 [details]
Patch
Comment 2 Antti Koivisto 2019-01-28 08:15:40 PST 
Comment on attachment 360342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360342&action=review

> Source/WebCore/ChangeLog:8
> +        This patch implements quirk margin value collpasing. There are a few "quirk" rules when it comes to margin collapsing.

collapsing

> Source/WebCore/ChangeLog:29
> +            - the collpased after value stays 1qem quirk value.

collapsed
Comment 3 zalan 2019-01-28 08:20:25 PST 
Committed r240583: <https://trac.webkit.org/changeset/240583>
Comment 4 Radar WebKit Bug Importer 2019-01-28 08:21:28 PST 
<rdar://problem/47597463>