WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193896
[LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
https://bugs.webkit.org/show_bug.cgi?id=193896
Summary
[LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through ma...
zalan
Reported
2019-01-27 21:55:33 PST
<div style="border: 1px solid green"> <div> <p> </div> </div> p's 16px quirk margin gets collapsed all the way up.
Attachments
Patch
(15.82 KB, patch)
2019-01-28 08:09 PST
,
zalan
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2019-01-28 08:09:55 PST
Created
attachment 360342
[details]
Patch
Antti Koivisto
Comment 2
2019-01-28 08:15:40 PST
Comment on
attachment 360342
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=360342&action=review
> Source/WebCore/ChangeLog:8 > + This patch implements quirk margin value collpasing. There are a few "quirk" rules when it comes to margin collapsing.
collapsing
> Source/WebCore/ChangeLog:29 > + - the collpased after value stays 1qem quirk value.
collapsed
zalan
Comment 3
2019-01-28 08:20:25 PST
Committed
r240583
: <
https://trac.webkit.org/changeset/240583
>
Radar WebKit Bug Importer
Comment 4
2019-01-28 08:21:28 PST
<
rdar://problem/47597463
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug