WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
193886
Formalize WebKitAdditions mechanism of LoadOptimizer
https://bugs.webkit.org/show_bug.cgi?id=193886
Summary
Formalize WebKitAdditions mechanism of LoadOptimizer
Jiewen Tan
Reported
2019-01-27 11:58:56 PST
Modernize AppLinks code in tryInterceptNavigation to use BlockPtr.
Attachments
Patch
(17.02 KB, patch)
2019-01-31 01:51 PST
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
Patch
(17.02 KB, patch)
2019-01-31 10:19 PST
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-01-31 01:41:27 PST
<
rdar://problem/47696809
>
Jiewen Tan
Comment 2
2019-01-31 01:51:55 PST
Created
attachment 360709
[details]
Patch
Jiewen Tan
Comment 3
2019-01-31 01:54:15 PST
Comment on
attachment 360709
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=360709&action=review
> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:496 > #if HAVE(LOAD_OPTIMIZER)
Should remove this marco.
Jiewen Tan
Comment 4
2019-01-31 10:19:08 PST
Created
attachment 360739
[details]
Patch
Brent Fulgham
Comment 5
2019-01-31 11:15:40 PST
Comment on
attachment 360739
[details]
Patch r=me
Jiewen Tan
Comment 6
2019-01-31 11:29:40 PST
Comment on
attachment 360739
[details]
Patch Thanks Brent for r+ the patch.
WebKit Commit Bot
Comment 7
2019-01-31 12:01:13 PST
Comment on
attachment 360739
[details]
Patch Clearing flags on attachment: 360739 Committed
r240805
: <
https://trac.webkit.org/changeset/240805
>
WebKit Commit Bot
Comment 8
2019-01-31 12:01:14 PST
All reviewed patches have been landed. Closing bug.
Jiewen Tan
Comment 9
2019-01-31 16:35:51 PST
A build fix is committed: Committed
r240828
: <
https://trac.webkit.org/changeset/240828
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug