Bug 193886 - Formalize WebKitAdditions mechanism of LoadOptimizer
Summary: Formalize WebKitAdditions mechanism of LoadOptimizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-27 11:58 PST by Jiewen Tan
Modified: 2019-01-31 16:35 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.02 KB, patch)
2019-01-31 01:51 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Patch (17.02 KB, patch)
2019-01-31 10:19 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-01-27 11:58:56 PST 
Modernize AppLinks code in tryInterceptNavigation to use BlockPtr.
Comment 1 Radar WebKit Bug Importer 2019-01-31 01:41:27 PST 
<rdar://problem/47696809>
Comment 2 Jiewen Tan 2019-01-31 01:51:55 PST 
Created attachment 360709 [details]
Patch
Comment 3 Jiewen Tan 2019-01-31 01:54:15 PST 
Comment on attachment 360709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360709&action=review

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:496
>  #if HAVE(LOAD_OPTIMIZER)

Should remove this marco.
Comment 4 Jiewen Tan 2019-01-31 10:19:08 PST 
Created attachment 360739 [details]
Patch
Comment 5 Brent Fulgham 2019-01-31 11:15:40 PST 
Comment on attachment 360739 [details]
Patch

r=me
Comment 6 Jiewen Tan 2019-01-31 11:29:40 PST 
Comment on attachment 360739 [details]
Patch

Thanks Brent for r+ the patch.
Comment 7 WebKit Commit Bot 2019-01-31 12:01:13 PST 
Comment on attachment 360739 [details]
Patch

Clearing flags on attachment: 360739

Committed r240805: <https://trac.webkit.org/changeset/240805>
Comment 8 WebKit Commit Bot 2019-01-31 12:01:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Jiewen Tan 2019-01-31 16:35:51 PST 
A build fix is committed:
Committed r240828: <https://trac.webkit.org/changeset/240828>