Bug 193879 - Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node
Summary: Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-26 20:33 PST by Simon Fraser (smfr)
Modified: 2019-01-29 13:33 PST (History)
7 users (show)

See Also:

Attachments
Patch (70.69 KB, patch)
2019-01-26 21:08 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-01-26 20:33:38 PST 
Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node
Comment 1 Simon Fraser (smfr) 2019-01-26 21:08:38 PST 
Created attachment 360265 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-01-26 21:11:35 PST 
<rdar://problem/47578495>
Comment 3 Simon Fraser (smfr) 2019-01-27 08:59:53 PST 
https://trac.webkit.org/changeset/240553/webkit
I fixed the crash too!
Comment 4 Ryan Haddad 2019-01-28 21:47:16 PST 
This change caused compositing/iframes/remove-reinsert-webview-with-iframe.html to consistently crash on iOS Simulator bots, significantly slowing down EWS:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r240636%20(2254)/compositing/iframes/remove-reinsert-webview-with-iframe-crash-log.txt
Comment 5 Frédéric Wang (:fredw) 2019-01-29 00:30:31 PST 
(In reply to Ryan Haddad from comment #4)
> This change caused
> compositing/iframes/remove-reinsert-webview-with-iframe.html to consistently
> crash on iOS Simulator bots, significantly slowing down EWS:
> https://build.webkit.org/results/
> Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r240636%20(2254)/
> compositing/iframes/remove-reinsert-webview-with-iframe-crash-log.txt

Trace looks similar to bug 193907.
Comment 6 Simon Fraser (smfr) 2019-01-29 13:33:52 PST 
Crashes should be fixed by https://trac.webkit.org/changeset/240677/webkit