Make sure WTF::generateObjectIdentifier() internal counter does not get duplicated at each call site. This can lead to hard to debug duplicate identifiers such as the one in Bug 193761.
Created attachment 360173 [details] Patch
ping review?
I guess a unit test could be written. Not sure whether worth it.
Comment on attachment 360173 [details] Patch Rejecting attachment 360173 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 360173, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=360173&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=193848&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 360173 from bug 193848. Fetching: https://bugs.webkit.org/attachment.cgi?id=360173 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 25 diffs from patch file(s). patching file Source/WTF/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WTF/WTF.xcodeproj/project.pbxproj Hunk #1 succeeded at 83 (offset -3 lines). Hunk #2 succeeded at 415 (offset -3 lines). Hunk #3 succeeded at 1035 (offset 4 lines). Hunk #4 FAILED at 1555. 1 out of 4 hunks FAILED -- saving rejects to file Source/WTF/WTF.xcodeproj/project.pbxproj.rej patching file Source/WTF/wtf/CMakeLists.txt patching file Source/WTF/wtf/ObjectIdentifier.cpp patching file Source/WTF/wtf/ObjectIdentifier.h patching file Source/WebCore/dom/Document.cpp Hunk #1 succeeded at 536 (offset 1 line). patching file Source/WebCore/dom/MessageChannel.cpp patching file Source/WebCore/dom/ScriptExecutionContext.cpp patching file Source/WebCore/history/HistoryItem.cpp patching file Source/WebCore/loader/DocumentLoader.cpp patching file Source/WebCore/page/DOMWindow.cpp patching file Source/WebCore/platform/Process.cpp patching file Source/WebCore/workers/service/ServiceWorkerJobData.cpp patching file Source/WebCore/workers/service/server/RegistrationDatabase.cpp Hunk #1 succeeded at 400 (offset 1 line). patching file Source/WebCore/workers/service/server/SWServer.cpp patching file Source/WebCore/workers/service/server/SWServerRegistration.cpp patching file Source/WebCore/workers/service/server/SWServerToContextConnection.cpp patching file Source/WebKit/Platform/IPC/Connection.cpp patching file Source/WebKit/UIProcess/ChildProcessProxy.h patching file Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp patching file Source/WebKit/UIProcess/WebBackForwardList.cpp patching file Source/WebKit/UIProcess/WebProcessPool.cpp Hunk #1 succeeded at 260 (offset 2 lines). patching file Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10932595
Created attachment 360463 [details] Patch
Created attachment 360465 [details] Patch
Comment on attachment 360465 [details] Patch Clearing flags on attachment: 360465 Committed r240661: <https://trac.webkit.org/changeset/240661>
All reviewed patches have been landed. Closing bug.
<rdar://problem/47635445>