Bug 193847 – Move parentProcessConnection from ChildProcess to {NetworkProcess, WebProcess, PluginProcess}

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Alex Christensen]

Move parentProcessConnection from ChildProcess to {NetworkProcess, WebProcess, PluginProcess}

[Alex Christensen]

Created attachment 360168 [details]
Patch

[Alex Christensen]

Comment on attachment 360168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360168&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:161
>      initialize(WTFMove(parameters));
> +
> +    m_connection = IPC::Connection::createClientConnection(parameters.connectionIdentifier, *this);

This uses parameters after it has been moved from.  Will fix.

[Alex Christensen]

Created attachment 360179 [details]
Patch

[Sam Weinig]

Comment on attachment 360179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360179&action=review

> Source/WebKit/ChangeLog:8
> +        This is paving the way for the NetworkProcess to be split into a NetworkProcess and set of NetworkConnectionToUIProcess containing the connections.

Can you tell me more about the future here?  Is the idea that NetworkProcess in the future will be system wide and will be able to communicate with multiple UIProcesses? If so, it seems like a better direction would be to make it so that NetworkProcess no longer derives from ChildProcess, since it's not a "child process" anymore.

[Alex Christensen]

Sam, this is a step towards exactly that, except we plan to have a system-wide NetworkProcess for only certain SPI users.

[Sam Weinig]

(In reply to Alex Christensen from comment #5)
> Sam, this is a step towards exactly that, except we plan to have a
> system-wide NetworkProcess for only certain SPI users.

Ok, I then I think it makes sense to not make this change to ChildProcess, and just make this new "SystemWideNetworkService" not derive from ChildProcess, since it isn't a "child process" anymore.

[Geoffrey Garen]

Comment on attachment 360179 [details]
Patch

What are some of the behaviors of ChildProcess that NetworkProcess will still want after it has multiple UI process clients? And what behaviors would remain unique to ChildProcess, and unsupported by NetworkProcess?

Could the shared behaviors meaningfully move into a shared base class named "AuxiliaryProcess"?

Answering these questions might help us understand the class relationships.