RESOLVED FIXED193844
Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess 
https://bugs.webkit.org/show_bug.cgi?id=193844
Summary Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initi...
Alex Christensen
Reported 2019-01-25 13:41:23 PST
Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
Attachments
Patch (3.53 KB, patch)
2019-01-25 13:42 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.87 KB, patch)
2019-01-25 15:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-25 13:42:07 PST
Created attachment 360155 [details] Patch
Andy Estes
Comment 2 2019-01-25 15:08:48 PST
Comment on attachment 360155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360155&action=review > Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm:50 > +extern "C" OSStatus SetApplicationIsDaemon(Boolean isDaemon); This should be in an SPI header.
Alex Christensen
Comment 3 2019-01-25 15:40:27 PST
Created attachment 360178 [details] Patch
Alex Christensen
Comment 4 2019-01-25 15:41:44 PST
http://trac.webkit.org/r240520
Radar WebKit Bug Importer
Comment 5 2019-01-25 15:42:27 PST
<rdar://problem/47564877>
Alexey Proskuryakov
Comment 6 2019-01-26 00:31:30 PST
Comment on attachment 360178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360178&action=review > Source/WebKit/ChangeLog:8 > + This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction. The radar quoted as explanation of why this is needed in NetworkProcess is ancient. I’m guessing that we either need it in all child processes, or in none. Is it still doing anything useful in NetworkProcess? Does it even have a WindowServer connection before this call?
Note You need to log in before you can comment on or make changes to this bug.