Bug 193838 – Web Inspector: REGRESSION: selecting a path component with no siblings does nothing

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. go to <https://devinrousso.com/demo/WebKit/canvas.html>
2. open the Canvas tab
3. select a Canvas "Card"
4. try to click the "Overview" path component

[Devin Rousso]

Created attachment 360150 [details]
Patch

[Matt Baker]

Comment on attachment 360150 [details]
Patch

r-, as I don't think removing allowsRepeatSelection is the right fix for this.

We rely on allowsRepeatSelection in the Debugger tab Call Stack tree. Selecting an already selected element should scroll the source code location into view. This change breaks that behavior.

[Devin Rousso]

Comment on attachment 360150 [details]
Patch

(In reply to Matt Baker from comment #2)
> We rely on allowsRepeatSelection in the Debugger tab Call Stack tree.
> Selecting an already selected element should scroll the source code location
> into view. This change breaks that behavior.
This is currently not working for me on ToT.  I don't think that issue has anything to do with this.  If anything, this change should help that, because by removing `allowsRepeatSelection`, we're effectively setting it to `true` for all `WI.TreeOutline`, so we should _always_ be able to reselect (and therefore re-scroll).  Resetting to r?.

[Devin Rousso]

(In reply to Devin Rousso from comment #3)
> (In reply to Matt Baker from comment #2)
> > We rely on allowsRepeatSelection in the Debugger tab Call Stack tree. Selecting an already selected element should scroll the source code location into view. This change breaks that behavior.
> This is currently not working for me on ToT.  I don't think that issue has anything to do with this.  If anything, this change should help that, because by removing `allowsRepeatSelection`, we're effectively setting it to `true` for all `WI.TreeOutline`, so we should _always_ be able to reselect (and therefore re-scroll).  Resetting to r?.
I believe this functionality regressed with the addition of `WI.SelectionController`.  `WI.SelectionController.prototype.selectItem` early-returns if the index is already selected, meaning we don't call `selectionControllerSelectionDidChange` (which therefore doesn't fire `WI.TreeOutline.Event.SelectionDidChange`).  Because of these changes, setting `allowsRepeatSelection` doesn't actually do anything.

Unfortunately, attachment 360150 [details] doesn't fix that issue :(

[Matt Baker]

I can no longer reproduce this.