RESOLVED FIXED 193809
Remove usage of internal macro from private header 
https://bugs.webkit.org/show_bug.cgi?id=193809
Summary Remove usage of internal macro from private header
Keith Miller
Reported 2019-01-24 19:23:22 PST
Remove usage of internal macro from private header
Attachments
Patch (9.43 KB, patch)
2019-01-24 19:25 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-01-24 19:25:10 PST
Created attachment 360072 [details] Patch
EWS Watchlist
Comment 2 2019-01-24 19:26:42 PST
Attachment 360072 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/tests/testIncludes.m:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2019-01-24 19:28:02 PST
Can you fix the style issue?
Keith Miller
Comment 4 2019-01-24 19:33:33 PST
(In reply to Saam Barati from comment #3) > Can you fix the style issue? The style issue is that the public umbrella header should be included after our private headers but I'd rather include the public header first.
WebKit Commit Bot
Comment 5 2019-01-24 20:39:38 PST
Comment on attachment 360072 [details] Patch Clearing flags on attachment: 360072 Committed r240468: <https://trac.webkit.org/changeset/240468>
WebKit Commit Bot
Comment 6 2019-01-24 20:39:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-24 20:40:29 PST
<rdar://problem/47538853>
Note You need to log in before you can comment on or make changes to this bug.