Bug 193809 - Remove usage of internal macro from private header
Summary: Remove usage of internal macro from private header
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
Keywords: InRadar
Depends on:
Reported: 2019-01-24 19:23 PST by Keith Miller
Modified: 2019-01-24 20:40 PST (History)
6 users (show)

See Also:

Patch (9.43 KB, patch)
2019-01-24 19:25 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-01-24 19:23:22 PST
Remove usage of internal macro from private header
Comment 1 Keith Miller 2019-01-24 19:25:10 PST
Created attachment 360072 [details]
Comment 2 EWS Watchlist 2019-01-24 19:26:42 PST
Attachment 360072 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/API/tests/testIncludes.m:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2019-01-24 19:28:02 PST
Can you fix the style issue?
Comment 4 Keith Miller 2019-01-24 19:33:33 PST
(In reply to Saam Barati from comment #3)
> Can you fix the style issue?

The style issue is that the public umbrella header should be included after our private headers but I'd rather include the public header first.
Comment 5 WebKit Commit Bot 2019-01-24 20:39:38 PST
Comment on attachment 360072 [details]

Clearing flags on attachment: 360072

Committed r240468: <https://trac.webkit.org/changeset/240468>
Comment 6 WebKit Commit Bot 2019-01-24 20:39:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-24 20:40:29 PST