Bug 193808 – REGRESSION(?): Web Inspector: Can have multiple Timelines selected after edit mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

REGRESSION: Can have multiple Timelines selected after edit mode

Steps to Reproduce:
1. Inspect this page
2. Show Timelines tab with multiple timelines
3. Select 1st timeline
4. Enter edit mode
  => No selection visible
5. Leave edit mode
  => Selection visible
6. Select 2nd timeline
  => Multiple timelines selected (unexpected)

[Radar WebKit Bug Importer]

<rdar://problem/47537734>

[Matt Baker]

Created attachment 360312 [details]
Patch

[Devin Rousso]

Comment on attachment 360312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360312&action=review

r=me, but I think we should write tests for patches that "fix a bug where...", so I'd like to see a test for this if possible

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:350
> +                treeOutline._selectionController.didRemoveItems(removedIndexes);

I'd personally rather have the early-return happen inside `didRemoveItems`.  Requiring the caller to know that you should only ever pass a non-null `WI.IndexSet` seems unnecessary, and is likely to be forgotten in the future.

Also, should we also be early-returning if `!removedIndexes.size`?

[Matt Baker]

Created attachment 360359 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 360359 [details]
Patch

Clearing flags on attachment: 360359

Committed r240594: <https://trac.webkit.org/changeset/240594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.