Bug 193801 - [JSC] RegExpConstructor should not have own IsoSubspace
Summary: [JSC] RegExpConstructor should not have own IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 193606
  Show dependency treegraph
 
Reported: 2019-01-24 16:41 PST by Yusuke Suzuki
Modified: 2019-01-28 11:53 PST (History)
6 users (show)

See Also:


Attachments
Patch (25.40 KB, patch)
2019-01-26 01:10 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (72.81 KB, patch)
2019-01-27 01:08 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (73.48 KB, patch)
2019-01-27 01:33 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (74.84 KB, patch)
2019-01-27 01:45 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.45 MB, application/zip)
2019-01-27 06:54 PST, EWS Watchlist
no flags Details
Patch (74.84 KB, patch)
2019-01-27 11:15 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (74.98 KB, patch)
2019-01-27 11:25 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-01-24 16:41:36 PST
We should extract per-JSGlobalObject data from RegExpConstructor, and put it in JSGlobalObject.
Comment 1 Yusuke Suzuki 2019-01-26 01:10:46 PST
Created attachment 360231 [details]
Patch

WIP
Comment 2 Yusuke Suzuki 2019-01-27 01:08:16 PST
Created attachment 360280 [details]
Patch
Comment 3 Yusuke Suzuki 2019-01-27 01:33:56 PST
Created attachment 360282 [details]
Patch
Comment 4 Yusuke Suzuki 2019-01-27 01:45:20 PST
Created attachment 360283 [details]
Patch
Comment 5 EWS Watchlist 2019-01-27 06:54:26 PST
Comment on attachment 360283 [details]
Patch

Attachment 360283 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10911158

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Comment 6 EWS Watchlist 2019-01-27 06:54:28 PST
Created attachment 360295 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 7 Yusuke Suzuki 2019-01-27 11:14:52 PST
(In reply to Build Bot from comment #6)
> Created attachment 360295 [details]
> Archive of layout-test-results from ews124 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

This is due to the test flakiness.
Comment 8 Yusuke Suzuki 2019-01-27 11:15:49 PST
Created attachment 360299 [details]
Patch
Comment 9 Yusuke Suzuki 2019-01-27 11:25:16 PST
Created attachment 360301 [details]
Patch
Comment 10 Mark Lam 2019-01-28 11:47:20 PST
Comment on attachment 360301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review

r=me

> Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61
> +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset)

nit: insert blank line before this.
Comment 11 Yusuke Suzuki 2019-01-28 11:50:05 PST
Comment on attachment 360301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review

>> Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61
>> +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset)
> 
> nit: insert blank line before this.

Nice, fixed.
Comment 12 Yusuke Suzuki 2019-01-28 11:52:22 PST
Committed r240593: <https://trac.webkit.org/changeset/240593>
Comment 13 Radar WebKit Bug Importer 2019-01-28 11:53:28 PST
<rdar://problem/47605248>