We should extract per-JSGlobalObject data from RegExpConstructor, and put it in JSGlobalObject.
Created attachment 360231 [details] Patch WIP
Created attachment 360280 [details] Patch
Created attachment 360282 [details] Patch
Created attachment 360283 [details] Patch
Comment on attachment 360283 [details] Patch Attachment 360283 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10911158 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Created attachment 360295 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #6) > Created attachment 360295 [details] > Archive of layout-test-results from ews124 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 This is due to the test flakiness.
Created attachment 360299 [details] Patch
Created attachment 360301 [details] Patch
Comment on attachment 360301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review r=me > Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61 > +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset) nit: insert blank line before this.
Comment on attachment 360301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review >> Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61 >> +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset) > > nit: insert blank line before this. Nice, fixed.
Committed r240593: <https://trac.webkit.org/changeset/240593>
<rdar://problem/47605248>