Bug 193800 - [JSC] ErrorConstructor should not have own IsoSubspace
Summary: [JSC] ErrorConstructor should not have own IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 193606
  Show dependency treegraph
 
Reported: 2019-01-24 16:39 PST by Yusuke Suzuki
Modified: 2019-01-24 18:49 PST (History)
6 users (show)

See Also:


Attachments
Patch (14.53 KB, patch)
2019-01-24 17:33 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (14.53 KB, patch)
2019-01-24 17:35 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (16.98 KB, patch)
2019-01-24 18:38 PST, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-01-24 16:39:26 PST
We can put stackTraceLimit information in JSGlobalObject instead.
Comment 1 Yusuke Suzuki 2019-01-24 17:33:13 PST
Created attachment 360061 [details]
Patch
Comment 2 Yusuke Suzuki 2019-01-24 17:35:05 PST
Created attachment 360062 [details]
Patch
Comment 3 Yusuke Suzuki 2019-01-24 18:34:32 PST
Comment on attachment 360062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360062&action=review

> Source/JavaScriptCore/runtime/ErrorConstructor.cpp:44
>      // ECMA 15.11.3.1 Error.prototype

I'll soon move callErrorConstructor and constructWithErrorConstructor from Interpreter to this file.
Comment 4 Yusuke Suzuki 2019-01-24 18:38:59 PST
Created attachment 360066 [details]
Patch
Comment 5 Yusuke Suzuki 2019-01-24 18:48:03 PST
Committed r240465: <https://trac.webkit.org/changeset/240465>
Comment 6 Radar WebKit Bug Importer 2019-01-24 18:49:28 PST
<rdar://problem/47537242>