Bug 193798 - iOS: Split keyboard should not shrink visualViewport.height
Summary: iOS: Split keyboard should not shrink visualViewport.height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 170982
  Show dependency tree / graph
 
Reported: 2019-01-24 16:36 PST by Ryosuke Niwa
Modified: 2019-01-24 18:53 PST (History)
5 users (show)

See Also:

Attachments
Fixes the bug (2.44 KB, patch)
2019-01-24 16:45 PST, Ryosuke Niwa 		thorton: review+
Details | Formatted Diff | Diff
Test patch (8.72 KB, patch)
2019-01-24 17:28 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-01-24 16:36:17 PST 
When the user brings up split keyboard, we should treat it like a floating keyboard and not shrink the height of visualViewport.height.

<rdar://problem/47504231>
Comment 1 Ryosuke Niwa 2019-01-24 16:45:14 PST 
Created attachment 360049 [details]
Fixes the bug
Comment 2 Simon Fraser (smfr) 2019-01-24 17:24:09 PST 
Comment on attachment 360049 [details]
Fixes the bug

Can we test this?
Comment 3 Ryosuke Niwa 2019-01-24 17:25:36 PST 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 360049 [details]
> Fixes the bug
> 
> Can we test this?

As I explained in the change log, it's possible to split the keyboard using some SPI but there isn't a reliable way to reset the state if the test gets terminated prematurely. Then iPad Simulator will be forever hosed until someone fixes it. I don't think we want to take that kind of bot maintenance risk.
Comment 4 Ryosuke Niwa 2019-01-24 17:28:04 PST 
Created attachment 360060 [details]
Test patch

Here's the patch to add test. It works but it can forever hose the iOS simulator with split keyboard...
Comment 5 Ryosuke Niwa 2019-01-24 18:53:29 PST 
Committed r240466: <https://trac.webkit.org/changeset/240466>