WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 193795
We should do constant folding on ValueOp even when it is UntypedUse
https://bugs.webkit.org/show_bug.cgi?id=193795
Summary
We should do constant folding on ValueOp even when it is UntypedUse
Caio Lima
Reported
2019-01-24 16:06:46 PST
Right now, we don't do constant fold on ValueOp nodes, but there is no reason why we shouldn't do this, since profiling and prediction propagation can miss some opportunities.
Attachments
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2019-01-24 16:27:26 PST
Yeah, the only thing we need to make sure of is that we don't fold away things that would've failed type checks. For UntypedUse that's obviously nothing. But for BigInt, we must make sure the inputs are BigInt.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug