Bug 193795 - We should do constant folding on ValueOp even when it is UntypedUse
Summary: We should do constant folding on ValueOp even when it is UntypedUse
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 186173
  Show dependency treegraph
 
Reported: 2019-01-24 16:06 PST by Caio Lima
Modified: 2019-01-24 16:27 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2019-01-24 16:06:46 PST
Right now, we don't do constant fold on ValueOp nodes, but there is no reason why we shouldn't do this, since profiling and prediction propagation can miss some opportunities.
Comment 1 Saam Barati 2019-01-24 16:27:26 PST
Yeah, the only thing we need to make sure of is that we don't fold away things that would've failed type checks. For UntypedUse that's obviously nothing. But for BigInt, we must make sure the inputs are BigInt.