Bug 193793 - Update WebKitAdditions.xcconfig with correct order of variable definitions
Summary: Update WebKitAdditions.xcconfig with correct order of variable definitions
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-01-24 15:59 PST by Keith Rollin
Modified: 2019-01-25 14:19 PST (History)
12 users (show)

See Also:

Patch (19.48 KB, patch)
2019-01-25 10:51 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-24 15:59:19 PST
XCBuild changes the way xcconfig variables are evaluated. In short, all config file assignments are now considered in part of the evaluation. When using the new build system and an .xcconfig file contains multiple assignments of the same build setting:

- Later assignments using $(inherited) will inherit from earlier assignments in the xcconfig file.
- Later assignments not using $(inherited) will take precedence over earlier assignments. An assignment to a more general setting will mask an earlier assignment to a less general setting. For example, an assignment without a condition ('FOO = bar') will completely mask an earlier assignment with a condition ('FOO[sdk=macos*] = quux').

This affects some of our .xcconfig files, in that sometimes platform- or sdk-specific definitions appear before the general definitions. Under the new evaluations rules, the general definitions alway take effect because they alway overwrite the more-specific definitions. The solution is to swap the order, so that the general definitions are established first, and then conditionally overwritten by the more-specific definitions.
Comment 1 Radar WebKit Bug Importer 2019-01-24 15:59:44 PST
Comment 2 Keith Rollin 2019-01-25 10:51:11 PST
Created attachment 360126 [details]
Comment 3 Alex Christensen 2019-01-25 13:50:17 PST
Comment on attachment 360126 [details]

I was under the impression that order didn't matter in these files, but if these changes are necessary, ok.
Comment 4 Keith Rollin 2019-01-25 13:57:20 PST
Your impression used to be correct.
Comment 5 WebKit Commit Bot 2019-01-25 14:19:30 PST
Comment on attachment 360126 [details]

Clearing flags on attachment: 360126

Committed r240508: <https://trac.webkit.org/changeset/240508>
Comment 6 WebKit Commit Bot 2019-01-25 14:19:32 PST
All reviewed patches have been landed.  Closing bug.