[webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path

[Jonathan Bedard]

Make iosSimulatorApplicationsPath more flexible to accommodate different runtime directories.

[Jonathan Bedard]

<rdar://problem/47497634>

[Jonathan Bedard]

Created attachment 360042 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 360042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360042&action=review

> Tools/ChangeLog:3
> +        [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in it's path

s/it's/its/

> Tools/Scripts/webkitdirs.pm:2509
> +    my @runtimes = grep {!/^\./} readdir(RUNTIMES);

Maybe check for ".simruntime" in the name?

> Tools/Scripts/webkitdirs.pm:2511
> +    return File::Spec->catdir($runtimePath, @runtimes ? $runtimes[0] : "iOS.simruntime", "Contents", "Resources", "RuntimeRoot", "Applications");

I suggest adding a FIXME here. Building the path manually is fragile, and randomly picking a single runtime path is just weird. We need to find a way to determine which runtime corresponds to a simulator that we're about to use.

[Jonathan Bedard]

Committed r240455: <https://trac.webkit.org/changeset/240455>

[Radar WebKit Bug Importer]

<rdar://problem/47533806>