RESOLVED FIXED 193783
Fix missing dependencies in extract-dependencies-from-makefile 
https://bugs.webkit.org/show_bug.cgi?id=193783
Summary Fix missing dependencies in extract-dependencies-from-makefile
Keith Rollin
Reported 2019-01-24 14:28:07 PST
The extract-dependencies-from-makefile script generates .xcfilelists for XCBuild by invoking a makefile in --debug mode, parsing the dependency information in the output, and extracting information regarding targets and dependents. However, the way `make` emits this dependency information is not rigorous, and so we need to determine what lines to look for and parse by trial and error. This approach didn't catch all the information we needed to collect, so update the script to look for the additional lines we now know to look for. rdar://problem/47201571
Attachments
Patch (2.93 KB, patch)
2019-01-24 16:50 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2019-01-24 16:50:11 PST
Created attachment 360052 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-25 13:51:08 PST
Comment on attachment 360052 [details] Patch Clearing flags on attachment: 360052 Committed r240503: <https://trac.webkit.org/changeset/240503>
WebKit Commit Bot
Comment 3 2019-01-25 13:51:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.