Bug 193783 - Fix missing dependencies in extract-dependencies-from-makefile
Summary: Fix missing dependencies in extract-dependencies-from-makefile
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-01-24 14:28 PST by Keith Rollin
Modified: 2019-01-25 13:51 PST (History)
6 users (show)

See Also:

Patch (2.93 KB, patch)
2019-01-24 16:50 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-24 14:28:07 PST
The extract-dependencies-from-makefile script generates .xcfilelists for XCBuild by invoking a makefile in --debug mode, parsing the dependency information in the output, and extracting information regarding targets and dependents. However, the way `make` emits this dependency information is not rigorous, and so we need to determine what lines to look for and parse by trial and error. This approach didn't catch all the information we needed to collect, so update the script to look for the additional lines we now know to look for.

Comment 1 Keith Rollin 2019-01-24 16:50:11 PST
Created attachment 360052 [details]
Comment 2 WebKit Commit Bot 2019-01-25 13:51:08 PST
Comment on attachment 360052 [details]

Clearing flags on attachment: 360052

Committed r240503: <https://trac.webkit.org/changeset/240503>
Comment 3 WebKit Commit Bot 2019-01-25 13:51:10 PST
All reviewed patches have been landed.  Closing bug.