Bug 193782 - Complete the implementation of generate-xcfilelists
Summary: Complete the implementation of generate-xcfilelists
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-01-24 14:20 PST by Keith Rollin
Modified: 2019-01-25 14:24 PST (History)
6 users (show)

See Also:

Patch (62.82 KB, patch)
2019-01-24 16:49 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-01-24 14:20:20 PST
A preliminary version of generate-xcfilelists was added in r238008. It needs to be updated in order to:

* Support checking of .xcfilelists
* Perform better execution of `make DerivedSources.make` by relaunching generate-xcfilelists under xcodebuild
* Support incremental generation and checking of .xcfilelists
* Support supplementary .xcfilelists files from WebKitAdditions
* Support being wrapped by parallel version of generate-xcfilelists in Internal that adds support for (re)generating WebKit projects in that repo.
* Support builds that have been performed in WebKitBuild as well as ~/Library/Developer/code/DerivedData
* Increase robustness and debugging facilities.

Comment 1 Keith Rollin 2019-01-24 16:49:24 PST
Created attachment 360051 [details]
Comment 2 Alex Christensen 2019-01-25 13:48:22 PST
Comment on attachment 360051 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review

Nothing jumps out as horribly wrong.

> Tools/Scripts/generate-xcfilelists:1
> +#!/bin/bash

Comment 3 Keith Rollin 2019-01-25 13:54:12 PST
As opposed to /bin/sh? We effectively use bash features in our other scripts that say /bin/sh, so I figured be clear about it. Also, it helps with my editor's highlighting if it knows that this is bash code and not plain old sh.

Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried away.
Comment 4 Alex Christensen 2019-01-25 13:55:06 PST
(In reply to Keith Rollin from comment #3)
> Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried
> away.
Seriously.  You should've used the most elegant language, which is of course Perl.
Comment 5 WebKit Commit Bot 2019-01-25 14:24:00 PST
Comment on attachment 360051 [details]

Clearing flags on attachment: 360051

Committed r240510: <https://trac.webkit.org/changeset/240510>
Comment 6 WebKit Commit Bot 2019-01-25 14:24:01 PST
All reviewed patches have been landed.  Closing bug.