RESOLVED FIXED 193782
Complete the implementation of generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=193782
Summary Complete the implementation of generate-xcfilelists
Keith Rollin
Reported 2019-01-24 14:20:20 PST
A preliminary version of generate-xcfilelists was added in r238008. It needs to be updated in order to: * Support checking of .xcfilelists * Perform better execution of `make DerivedSources.make` by relaunching generate-xcfilelists under xcodebuild * Support incremental generation and checking of .xcfilelists * Support supplementary .xcfilelists files from WebKitAdditions * Support being wrapped by parallel version of generate-xcfilelists in Internal that adds support for (re)generating WebKit projects in that repo. * Support builds that have been performed in WebKitBuild as well as ~/Library/Developer/code/DerivedData * Increase robustness and debugging facilities. <rdar://problem/47201505>
Attachments
Patch (62.82 KB, patch)
2019-01-24 16:49 PST, Keith Rollin
no flags
Keith Rollin
Comment 1 2019-01-24 16:49:24 PST
Alex Christensen
Comment 2 2019-01-25 13:48:22 PST
Comment on attachment 360051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review Nothing jumps out as horribly wrong. > Tools/Scripts/generate-xcfilelists:1 > +#!/bin/bash bash?!?!
Keith Rollin
Comment 3 2019-01-25 13:54:12 PST
As opposed to /bin/sh? We effectively use bash features in our other scripts that say /bin/sh, so I figured be clear about it. Also, it helps with my editor's highlighting if it knows that this is bash code and not plain old sh. Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried away.
Alex Christensen
Comment 4 2019-01-25 13:55:06 PST
(In reply to Keith Rollin from comment #3) > Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried > away. Seriously. You should've used the most elegant language, which is of course Perl.
WebKit Commit Bot
Comment 5 2019-01-25 14:24:00 PST
Comment on attachment 360051 [details] Patch Clearing flags on attachment: 360051 Committed r240510: <https://trac.webkit.org/changeset/240510>
WebKit Commit Bot
Comment 6 2019-01-25 14:24:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.