Bug 193782 – Complete the implementation of generate-xcfilelists

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

A preliminary version of generate-xcfilelists was added in r238008. It needs to be updated in order to:

* Support checking of .xcfilelists
* Perform better execution of `make DerivedSources.make` by relaunching generate-xcfilelists under xcodebuild
* Support incremental generation and checking of .xcfilelists
* Support supplementary .xcfilelists files from WebKitAdditions
* Support being wrapped by parallel version of generate-xcfilelists in Internal that adds support for (re)generating WebKit projects in that repo.
* Support builds that have been performed in WebKitBuild as well as ~/Library/Developer/code/DerivedData
* Increase robustness and debugging facilities.


<rdar://problem/47201505>

[Keith Rollin]

Created attachment 360051 [details]
Patch

[Alex Christensen]

Comment on attachment 360051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review

Nothing jumps out as horribly wrong.

> Tools/Scripts/generate-xcfilelists:1
> +#!/bin/bash

bash?!?!

[Keith Rollin]

As opposed to /bin/sh? We effectively use bash features in our other scripts that say /bin/sh, so I figured be clear about it. Also, it helps with my editor's highlighting if it knows that this is bash code and not plain old sh.

Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried away.

[Alex Christensen]

(In reply to Keith Rollin from comment #3)
> Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried
> away.
Seriously.  You should've used the most elegant language, which is of course Perl.

[WebKit Commit Bot]

Comment on attachment 360051 [details]
Patch

Clearing flags on attachment: 360051

Committed r240510: <https://trac.webkit.org/changeset/240510>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.