Bug 193780 - [iOS] Silence MediaPlayer compile warnings
Summary: [iOS] Silence MediaPlayer compile warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2019-01-24 14:05 PST by Eric Carlson
Modified: 2019-01-24 18:00 PST (History)
5 users (show)

See Also:

Patch (2.44 KB, patch)
2019-01-24 14:25 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-01-24 14:05:01 PST
Silence MediaPlayer compile warnings
Comment 1 Eric Carlson 2019-01-24 14:05:27 PST
Comment 2 Eric Carlson 2019-01-24 14:25:44 PST
Created attachment 360038 [details]
Comment 3 EWS Watchlist 2019-01-24 14:28:37 PST
Attachment 360038 [details] did not pass style-queue:

ERROR: Source/WebCore/PAL/pal/spi/ios/MediaPlayerSPI.h:37:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2019-01-24 18:00:06 PST
Comment on attachment 360038 [details]

Clearing flags on attachment: 360038

Committed r240461: <https://trac.webkit.org/changeset/240461>
Comment 5 WebKit Commit Bot 2019-01-24 18:00:08 PST
All reviewed patches have been landed.  Closing bug.