Bug 193773 – [css-logical] inset shorthand should not accept unitless length quirk

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Oriol Brufau]

https://github.com/w3c/csswg-drafts/issues/3525
RESOLVED: Do not allow quirks in 'inset' shorthand

Only the longhands and shorthands explicitly listed in
https://quirks.spec.whatwg.org/#the-unitless-length-quirk
should accept unitless lengths.

[Oriol Brufau]

Created attachment 360021 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 360021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360021&action=review

LGTM, maybe we need one more test check the comments inline.

> Source/WebCore/ChangeLog:10
> +        should reject it.

Could you link the CSSWG discussion or the spec here? Thanks.

> LayoutTests/imported/w3c/ChangeLog:9
> +        allowed in the 'inset' shorthand.

Is there any test checking that unitless lenghts are still allowed on quirks mode?

[Oriol Brufau]

Created attachment 360335 [details]
Patch

[Oriol Brufau]

(In reply to Manuel Rego Casasnovas from comment #2)
> > LayoutTests/imported/w3c/ChangeLog:9
> > +        allowed in the 'inset' shorthand.
> 
> Is there any test checking that unitless lenghts are still allowed on quirks
> mode?

I have imported the other unitless-length tests, which check top,right,bottom,left properties (among others).

[WebKit Commit Bot]

Comment on attachment 360335 [details]
Patch

Clearing flags on attachment: 360335

Committed r240588: <https://trac.webkit.org/changeset/240588>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47599692>