RESOLVED: Do not allow quirks in 'inset' shorthand
Only the longhands and shorthands explicitly listed in
should accept unitless lengths.
Created attachment 360021 [details]
Comment on attachment 360021 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=360021&action=review
LGTM, maybe we need one more test check the comments inline.
> + should reject it.
Could you link the CSSWG discussion or the spec here? Thanks.
> + allowed in the 'inset' shorthand.
Is there any test checking that unitless lenghts are still allowed on quirks mode?
Created attachment 360335 [details]
(In reply to Manuel Rego Casasnovas from comment #2)
> > LayoutTests/imported/w3c/ChangeLog:9
> > + allowed in the 'inset' shorthand.
> Is there any test checking that unitless lenghts are still allowed on quirks
I have imported the other unitless-length tests, which check top,right,bottom,left properties (among others).
Comment on attachment 360335 [details]
Clearing flags on attachment: 360335
Committed r240588: <https://trac.webkit.org/changeset/240588>
All reviewed patches have been landed. Closing bug.