Bug 193753 – Add "frame hosting" nodes to the scrolling tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Add "frame hosting" nodes to the scrolling tree

[Simon Fraser (smfr)]

Created attachment 359982 [details]
Patch

[EWS Watchlist]

Attachment 359982 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

We may need to give these FrameHosting nodes some geometry (representing the offsets of the RenderIFrame from their scrolling node ancestor), so that the ScrollingTreeFrameScrollingNode's geometry doesn't need to account for offsets which belong to a different document.

[Antti Koivisto]

Comment on attachment 359982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359982&action=review

> Source/WebCore/page/scrolling/ios/ScrollingTreeIOS.cpp:94
>      case ScrollingNodeType::Subframe:
>          return ScrollingTreeFrameScrollingNodeIOS::create(*this, nodeType, nodeID);
> +    case ScrollingNodeType::FrameHosting:
> +        return ScrollingTreeFrameHostingNode::create(*this, nodeID);

Is this code (web process side scrolling tree on iOS) actually ever used?

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 359982 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359982&action=review
> 
> > Source/WebCore/page/scrolling/ios/ScrollingTreeIOS.cpp:94
> >      case ScrollingNodeType::Subframe:
> >          return ScrollingTreeFrameScrollingNodeIOS::create(*this, nodeType, nodeID);
> > +    case ScrollingNodeType::FrameHosting:
> > +        return ScrollingTreeFrameHostingNode::create(*this, nodeID);
> 
> Is this code (web process side scrolling tree on iOS) actually ever used?

No. I was hoping to use is for iOS WK1 (UIWebView) but that never happened.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/240435/webkit

[Radar WebKit Bug Importer]

<rdar://problem/47516161>

[Antti Koivisto]

> No. I was hoping to use is for iOS WK1 (UIWebView) but that never happened.

Let's remove it then to reduce general confusion.

[Simon Fraser (smfr)]

(In reply to Antti Koivisto from comment #8)
> > No. I was hoping to use is for iOS WK1 (UIWebView) but that never happened.
> 
> Let's remove it then to reduce general confusion.

I tried, and found that RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS inherits from WebCore/ScrollingTreeFrameScrollingNodeIOS so fixing this is a bit more involved.