Bug 193752 - REGRESSION: [ MacOS iOS Release ] Layout Test http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html is flaky
Summary: REGRESSION: [ MacOS iOS Release ] Layout Test http/tests/resourceLoadStatisti...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-23 18:00 PST by Truitt Savell
Modified: 2022-02-12 19:06 PST (History)
6 users (show)

See Also:


Attachments
test list (194.95 KB, text/plain)
2019-01-23 18:30 PST, Truitt Savell
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-01-23 18:00:28 PST
The following layout test is flaky on MacOS and iOS Release

http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html

Probable cause:

Test became flaky very recently around r240360. It suddenly failed across several platforms. Attempted repro by just iterating the test 5000 times but this caused no failures. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fcap-cache-max-age-for-prevalent-resource.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource-actual.txt
@@ -4,11 +4,12 @@
 
 
 PASS loadedUrl is "http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=1234"
-PASS loadedUrl is "http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=4321"
-PASS loadedUrl is "http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value="
-PASS loadedUrl is "http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value="
-PASS loadedUrl is "http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value="
+FAIL loadedUrl should be http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=4321. Was http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=1234.
+FAIL loadedUrl should be http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=. Was http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=1234.
+FAIL loadedUrl should be http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=. Was http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=1234.
+FAIL loadedUrl should be http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=. Was http://localhost:8000/resourceLoadStatistics/resources/echo-query.php?value=1234.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
Comment 1 Truitt Savell 2019-01-23 18:30:52 PST
Created attachment 359981 [details]
test list

this test list run with one child process was able to reproduce the failure local
Comment 2 Truitt Savell 2019-01-23 18:33:11 PST
used command:
run-webkit-tests --root testbuild-240366 --test-list test1 --child-processes 1

This reproduced the failure on the first attempt. I have not reproduced repeatedly yet. 

This indicates that this failure may have been caused by a test earlier in the run.
Comment 3 Truitt Savell 2019-01-24 13:58:49 PST
test is flakey when reproducing as well. attempting to bisect the failure
Comment 4 Truitt Savell 2019-01-24 14:03:25 PST
This tests may also be related, began failing around the same time: 

http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js.html

history:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fcapped-lifetime-for-cookie-set-in-js.html
Comment 5 Radar WebKit Bug Importer 2019-01-25 10:18:27 PST
<rdar://problem/47553061>
Comment 6 Truitt Savell 2019-01-25 13:57:40 PST
I believe this test http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html became flakey with r240360. with my repro steps above I bisected down to this revision. I am able to get a failure on r240360 but have yet to get a failure on 240359 after about 20 attempts locally.
Comment 7 Brent Fulgham 2019-01-25 14:59:53 PST
(In reply to Truitt Savell from comment #6)
> I believe this test
> http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.
> html became flakey with r240360. with my repro steps above I bisected down
> to this revision. I am able to get a failure on r240360 but have yet to get
> a failure on 240359 after about 20 attempts locally.

You can’t skip the test (referencing this bug) if you want. I have a few more steps in the refactoring aimed at resolving these issues.
Comment 8 Brent Fulgham 2019-01-25 16:31:37 PST
(In reply to Brent Fulgham from comment #7)
> (In reply to Truitt Savell from comment #6)
> > I believe this test
> > http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.
> > html became flakey with r240360. with my repro steps above I bisected down
> > to this revision. I am able to get a failure on r240360 but have yet to get
> > a failure on 240359 after about 20 attempts locally.
> 
> You can’t skip the test (referencing this bug) if you want. I have a few
> more steps in the refactoring aimed at resolving these issues.

By can't I meant CAN.

Also: One of the causes of flaky timeouts should be resolved in r240509.