Bug 193745 - [iOS] Enable media element volume on iPad
Summary: [iOS] Enable media element volume on iPad
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2019-01-23 16:11 PST by Eric Carlson
Modified: 2019-01-24 07:31 PST (History)
4 users (show)

See Also:

Patch (4.87 KB, patch)
2019-01-23 16:20 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-01-23 16:11:46 PST
Enable media element volume on iPad
Comment 1 Eric Carlson 2019-01-23 16:12:17 PST
Comment 2 Eric Carlson 2019-01-23 16:20:55 PST
Created attachment 359969 [details]
Comment 3 Jon Lee 2019-01-23 16:29:12 PST
Comment on attachment 359969 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=359969&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5341
> +

Why shouldn't this be preserved if not iPad?
Comment 4 WebKit Commit Bot 2019-01-24 07:31:07 PST
Comment on attachment 359969 [details]

Clearing flags on attachment: 359969

Committed r240434: <https://trac.webkit.org/changeset/240434>
Comment 5 WebKit Commit Bot 2019-01-24 07:31:09 PST
All reviewed patches have been landed.  Closing bug.