Bug 193743 – Web Inspector: Audit: remove experimental setting

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Turn the Audit tab on by default \(0.0)/

[Devin Rousso]

<rdar://problem/28234022>

[Devin Rousso]

Created attachment 359967 [details]
Patch

[Devin Rousso]

Should we do anything for the situation where the user had already opened WebInspector?  In that case, they'd already have a list of open tabs, and we wouldn't add the Audit tab to that list (it's only in the `defaultValue` list).  If so, that would probably mean adding another semi-permanent setting 😅 that gets set when we force-add the Audit tab (so it only get's added once and won't reappear if the user then removes it themselves).

[Joseph Pecoraro]

Comment on attachment 359967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359967&action=review

> Source/WebInspectorUI/ChangeLog:13
> +        (WI.Setting.migrateValue):
> +        Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`.

This should really be done separately, since you aren't using it here the drive-by is totally unrelated.

> Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:-53
> -    static isTabAllowed()
> -    {
> -        return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value;
> -    }

I still think we will want to disable this for ServiceWorkers and JSContexts... basically only allow this for Web Pages:

    static isTabAllowed()
    {
        return WI.sharedApp.debuggableType === WI.DebuggableType.Web;
    }

[Devin Rousso]

Created attachment 360151 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 360151 [details]
Patch

Clearing flags on attachment: 360151

Committed r240502: <https://trac.webkit.org/changeset/240502>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.