Turn the Audit tab on by default \(0.0)/
<rdar://problem/28234022>
Created attachment 359967 [details] Patch
Should we do anything for the situation where the user had already opened WebInspector? In that case, they'd already have a list of open tabs, and we wouldn't add the Audit tab to that list (it's only in the `defaultValue` list). If so, that would probably mean adding another semi-permanent setting 😅 that gets set when we force-add the Audit tab (so it only get's added once and won't reappear if the user then removes it themselves).
Comment on attachment 359967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359967&action=review > Source/WebInspectorUI/ChangeLog:13 > + (WI.Setting.migrateValue): > + Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`. This should really be done separately, since you aren't using it here the drive-by is totally unrelated. > Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:-53 > - static isTabAllowed() > - { > - return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value; > - } I still think we will want to disable this for ServiceWorkers and JSContexts... basically only allow this for Web Pages: static isTabAllowed() { return WI.sharedApp.debuggableType === WI.DebuggableType.Web; }
Created attachment 360151 [details] Patch
Comment on attachment 360151 [details] Patch Clearing flags on attachment: 360151 Committed r240502: <https://trac.webkit.org/changeset/240502>
All reviewed patches have been landed. Closing bug.