Bug 193723 - REGRESSION (Probably r240243): CrashTracer: WebKitTestRunnerApp at com.apple.WebKit: WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const + 32
Summary: REGRESSION (Probably r240243): CrashTracer: WebKitTestRunnerApp at com.apple....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 193556
Blocks:
  Show dependency treegraph
 
Reported: 2019-01-23 08:54 PST by Brent Fulgham
Modified: 2019-01-23 10:44 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.11 KB, patch)
2019-01-23 08:57 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-01-23 08:54:39 PST
The new code in Bug 193556 could attempt to submit telemetry after the relevant WebResourceLoadStatisticsStore was destroyed. We should guard against this possibility.
Comment 1 Brent Fulgham 2019-01-23 08:55:09 PST
<rdar://problem/47476802>
Comment 2 Brent Fulgham 2019-01-23 08:57:08 PST
Created attachment 359893 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2019-01-23 10:19:13 PST
Comment on attachment 359893 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-01-23 10:44:40 PST
Comment on attachment 359893 [details]
Patch

Clearing flags on attachment: 359893

Committed r240346: <https://trac.webkit.org/changeset/240346>
Comment 5 WebKit Commit Bot 2019-01-23 10:44:41 PST
All reviewed patches have been landed.  Closing bug.